rt: fix new yield_now behavior with block_in_place #5251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #5223 changed the behavior of `yield_now()` to store yielded tasks and notify them *after* polling the resource drivers. This PR fixes a couple of bugs with this new behavior when combined with `block_in_place()`. First, we need to avoid freeing the deferred task queue when exiting a runtime if it is *not* the root runtime. Because `block_in_place()` allows a user to start a new runtime from within an existing task, this check is necessary. Second, when a worker core is stolen from a thread during a `block_in_place()` call, we need to ensure that deferred tasks are notified anyway.
carllerche
added
C-bug
carllerche
commented
Dec 1, 2022
| // Catching panics on worker threads in tests is quite tricky. Instead, when | ||
| // debug assertions are enabled, we just abort the process. | ||
| #[cfg(debug_assertions)] | ||
| let _abort_on_panic = AbortOnPanic; |
There was a problem hiding this comment.
This is just for tests and hopefully catching issues sooner.
Noah-Kennedy
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5223 changed the behavior of
yield_now()to store yielded tasks and notify them after polling the resource drivers. This PR fixes two bugs with this new behavior when combined withblock_in_place().First, we must avoid freeing the deferred task queue when exiting a runtime if it is not the root runtime. Because
block_in_place()allows a user to start a new runtime from within an existing task, this check is necessary.Second, when a worker core is stolen from a thread during a
block_in_place()call, we need to ensure that deferred tasks are notified.