Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: wake local tasks to the local queue when woken by the same thread #5095

Merged
merged 22 commits into from Oct 13, 2022
Merged

task: wake local tasks to the local queue when woken by the same thread #5095

merged 22 commits into from Oct 13, 2022

Commits on Oct 12, 2022

  1. (messy) test that tasks are woken to local queue

    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    9983f4a View commit details
    Browse the repository at this point in the history

  2. wake tasks locally if woken by the same thread

    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    a0b7574 View commit details
    Browse the repository at this point in the history

  3. avoid an Arc clone every time we get a thread id 

    this also handles the annoying issue that the thread id's value is not
guaranteed to be correct while dropping a thread-local...
    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    51b4a9f View commit details
    Browse the repository at this point in the history

  4. whoops, fix unstable

    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    26703d6 View commit details
    Browse the repository at this point in the history

  5. debug_assert still compiles code

    @carllerche @hawkw
    carllerche authored and hawkw committed Oct 12, 2022
    Copy the full SHA
    eadd363 View commit details
    Browse the repository at this point in the history

  6. see if CI passes

    @carllerche @hawkw
    carllerche authored and hawkw committed Oct 12, 2022
    Copy the full SHA
    b9df4d1 View commit details
    Browse the repository at this point in the history

  7. try again

    @carllerche @hawkw
    carllerche authored and hawkw committed Oct 12, 2022
    Copy the full SHA
    453deb6 View commit details
    Browse the repository at this point in the history

  8. fix clippy

    @carllerche @hawkw
    carllerche authored and hawkw committed Oct 12, 2022
    Copy the full SHA
    1dc9d4d View commit details
    Browse the repository at this point in the history

  9. rewrite test to avoid io

    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    a2cf00f View commit details
    Browse the repository at this point in the history

  10. use loom thread IDs (whoops!) 

    i forgot to import `Thread`/`ThreadId` from `loom` to use
the mocked thread IDs during loom runs. this should debreak the loom
tests.
    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    51a3b66 View commit details
    Browse the repository at this point in the history

  11. rm unused test code

    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    80a501a View commit details
    Browse the repository at this point in the history

  12. try to get a panic message out of macos ci

    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    4e97d74 View commit details
    Browse the repository at this point in the history

  13. ladies and gentlemen, we got him

    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    c4e0cc1 View commit details
    Browse the repository at this point in the history

  14. fix possible double panic while dropping

    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    f2564c1 View commit details
    Browse the repository at this point in the history

  15. +docs

    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    1aa7a39 View commit details
    Browse the repository at this point in the history

  16. put back const thread local 

    (that wasn't actually why loom failed)
    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    75c93b8 View commit details
    Browse the repository at this point in the history

  17. whoops

    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    ba7b63f View commit details
    Browse the repository at this point in the history

  18. we already have a thread-local macro that Does The Right THing

    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    6ce9caa View commit details
    Browse the repository at this point in the history

  19. just don't make the assertion on drop

    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    6350e87 View commit details
    Browse the repository at this point in the history

  20. try to disambiguate macro resolution

    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    61b29c6 View commit details
    Browse the repository at this point in the history

  21. Revert "try to disambiguate macro resolution" 

    This reverts commit 61b29c6.
    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    1f5f645 View commit details
    Browse the repository at this point in the history

  22. Revert "we already have a thread-local macro that Does The Right THing" 

    This reverts commit 6ce9caa.
    @hawkw
    hawkw committed Oct 12, 2022
    Copy the full SHA
    8043849 View commit details
    Browse the repository at this point in the history