Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make copy continue filling the buffer when writer stalls #5066

Merged
merged 7 commits into from Oct 3, 2022
Merged

make copy continue filling the buffer when writer stalls #5066

merged 7 commits into from Oct 3, 2022

Commits on Sep 30, 2022

  1. benchmarks for copying 

    Before the changes to read more often:

test copy_chunk_to_mem      ... bench: 128,141,778 ns/iter (+/- 410,047)
test copy_chunk_to_slow_hdd ... bench: 161,070,661 ns/iter (+/- 4,341,313)
test copy_mem_to_mem        ... bench:      13,400 ns/iter (+/- 346)
test copy_mem_to_slow_hdd   ... bench: 181,176,810 ns/iter (+/- 222,276)
    @farnz
    farnz committed Sep 30, 2022
    Copy the full SHA
    efe15e3 View commit details
    Browse the repository at this point in the history

  2. make copy read whenever it can't write until the buffer is full 

    After this:

test copy_chunk_to_mem      ... bench: 128,117,779 ns/iter (+/- 443,280)
test copy_chunk_to_slow_hdd ... bench: 141,173,126 ns/iter (+/- 348,824)
test copy_mem_to_mem        ... bench:      13,853 ns/iter (+/- 291)
test copy_mem_to_slow_hdd   ... bench: 181,171,138 ns/iter (+/- 343,375)
    @farnz
    farnz committed Sep 30, 2022
    Copy the full SHA
    217d6e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2022

  1. clippy

    @farnz
    farnz committed Oct 1, 2022
    Copy the full SHA
    79c78e5 View commit details
    Browse the repository at this point in the history

  2. Don't continue reading after read done, even in the write side

    @farnz
    farnz committed Oct 1, 2022
    Copy the full SHA
    44adc62 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Take @Darksonn's review suggestions

    @farnz
    farnz committed Oct 3, 2022
    Copy the full SHA
    d1ac168 View commit details
    Browse the repository at this point in the history

  2. oops - if the read doesn't claim success, the buffer shouldn't change

    @farnz
    farnz committed Oct 3, 2022
    Copy the full SHA
    dadb7c2 View commit details
    Browse the repository at this point in the history

  3. check success, not progress

    @farnz
    farnz committed Oct 3, 2022
    Copy the full SHA
    4299c85 View commit details
    Browse the repository at this point in the history