Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rt: move time driver into runtime module #4983

Merged
merged 1 commit into from Sep 6, 2022
Merged

Conversation

carllerche
Copy link
Member

This patch moves the time driver into the runtime module. The time driver
is a runtime concern and is only used by the runtime. Moving the drivers
is the first step to cleaning up some Tokio internals. There will be
follow-up patches that integrate the drivers and other runtime concerns
more closely.

This is an internal refactor and should not impact any public APIs.

Similar to #4942

This patch moves the time driver into the runtime module. The time driver
is a runtime concern and is only used by the runtime. Moving the drivers
is the first step to cleaning up some Tokio internals. There will be
follow-up patches that integrate the drivers and other runtime concerns
more closely.

This is an internal refactor and should not impact any public APIs.
@github-actions github-actions bot added the R-loom Run loom tests on this PR label Sep 6, 2022
@Noah-Kennedy
Copy link
Contributor

It looks like some tests were deleted. What was the reasoning there?

@carllerche
Copy link
Member Author

@Noah-Kennedy they were not necessary. Both were duplicates.

@carllerche carllerche merged commit bbfd34f into master Sep 6, 2022
@carllerche carllerche deleted the move-time-driver-to-rt branch September 6, 2022 21:12
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime M-time Module: tokio/time labels Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime M-time Module: tokio/time R-loom Run loom tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants