Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display JoinMap on docs.rs #4689

Merged
merged 2 commits into from May 14, 2022
Merged

Display JoinMap on docs.rs #4689

merged 2 commits into from May 14, 2022

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented May 14, 2022 •
edited

Currently, the new JoinMap introduced by #4640 would not be visible on docs.rs because we don't enable unstable features.

@Darksonn Darksonn added T-docs Topic: documentation A-tokio-util Area: The tokio-util crate labels May 14, 2022
@Darksonn Darksonn requested a review from hawkw May 14, 2022 10:18
hawkw
hawkw approved these changes May 14, 2022
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, i must have forgotten to make this change for tokio-util when i did it for tokio proper — good catch!

@Darksonn Darksonn merged commit ce0e115 into tokio-rs:master May 14, 2022
@Darksonn Darksonn deleted the joinmap-docsrs branch May 14, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate T-docs Topic: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Darksonn @hawkw