add required winapi features #4664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are a bunch of features that tokio source uses but not enable itself. this appear to be being enabled through dev-dependencies and the new feature resolution results in them not being on and the code not building in release
|
This seems like it is a duplicate of #4663? |
|
ah yea, great minds and all that 👀 #4663 adds more features than needed and always rather than per feature though |
|
Right now I just want to get a fix out. We can fine tune when the features need to be enabled later. |
|
makes sense |
|
on closer inspection mine's wrong anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are a bunch of features that tokio source uses but not enable itself. this appear to be being enabled through dev-dependencies and the new feature resolution results in them not being on and the code not building in release
fixes #4662
not sure how to test this though... i did it manually by removing all the dev-dependencies and changing to rust 2021