Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recover when OS fails to spawn a new thread #4485

Merged
merged 5 commits into from Feb 25, 2022
Merged

recover when OS fails to spawn a new thread #4485

merged 5 commits into from Feb 25, 2022

Commits on Feb 9, 2022

  1. recover when OS fails to spawn a new thread 

    Avoid panicking when the OS reaches the limit of the number of
threads / processes and the error is temporary.

Spawning a new thread is not mandatory to make progress as
long as there is a least one thread in the pool already processing
the task queue.

Fixes: tokio-rs#2309
    @gwik
    gwik committed Feb 9, 2022
    Copy the full SHA
    817f95a View commit details
    Browse the repository at this point in the history

  2. contain the panicking logic to one place 

    Co-authored-by: Eliza Weisman <eliza@buoyant.io>
    @gwik @hawkw
    gwik and hawkw committed Feb 9, 2022
    Copy the full SHA
    004c5fd View commit details
    Browse the repository at this point in the history

  3. fix after merging suggestion

    @gwik
    gwik committed Feb 9, 2022
    Copy the full SHA
    11bbb65 View commit details
    Browse the repository at this point in the history

  4. sugg std::io::Result 

    Co-authored-by: Eliza Weisman <eliza@buoyant.io>
    @gwik @hawkw
    gwik and hawkw committed Feb 9, 2022
    Copy the full SHA
    27d804a View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. remove OutOfMemory and comment 

    OutOfMemory is not available in 1.49 and I can't find
a reproducible scenario anyway.

The fix works on Windows and mac OS so removing the comment.
    @gwik
    gwik committed Feb 10, 2022
    Copy the full SHA
    e9f284e View commit details
    Browse the repository at this point in the history