New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
io: make duplex stream cooperative (#4470) #4478
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0b9acc6
io: make duplex stream cooperative (#4470)
GongLG a9d580f
Merge branch 'tokio-rs:master' into master
GongLG 6a3b85d
io: make duplex stream cooperative (#4470)
GongLG 5031a54
io: make duplex stream cooperative (#4470)
GongLG 40416b3
Merge branch 'tokio-rs:master' into master
GongLG 26c26c4
io: make duplex stream cooperative (#4470)
GongLG File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -100,3 +100,22 @@ async fn max_write_size() { | |||||||||||||||||
// drop b only after task t1 finishes writing | ||||||||||||||||||
drop(b); | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
#[tokio::test] | ||||||||||||||||||
async fn duplex_is_cooperative() { | ||||||||||||||||||
let (mut tx, mut rx) = tokio::io::duplex(1024 * 8); | ||||||||||||||||||
|
||||||||||||||||||
tokio::select! { | ||||||||||||||||||
biased; | ||||||||||||||||||
|
||||||||||||||||||
_ = async { | ||||||||||||||||||
loop { | ||||||||||||||||||
let buf = [3u8; 4096]; | ||||||||||||||||||
let _ = tx.write_all(&buf).await; | ||||||||||||||||||
let mut buf = [0u8; 4096]; | ||||||||||||||||||
let _ = rx.read(&mut buf).await; | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||
} | ||||||||||||||||||
} => {}, | ||||||||||||||||||
_ = tokio::task::yield_now() => {} | ||||||||||||||||||
} | ||||||||||||||||||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're getting a CI failure due to some warnings about these being unnecessary:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah..yeah..I fixed it once because the warning showed up in local build, but I guess I messed up git merge so this isn't removed here. Thanks I will fix it.