Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

track caller in tokio-util #4445

Closed
wants to merge 1 commit into from
Closed

track caller in tokio-util #4445

wants to merge 1 commit into from

Conversation

Noah-Kennedy
Copy link
Contributor

closes #4413

@github-actions github-actions bot added the R-loom Run loom tests on this PR label Jan 29, 2022
@Darksonn Darksonn added the A-tokio-util Area: The tokio-util crate label Jan 30, 2022
xD-saleem
xD-saleem reviewed Feb 1, 2022
View reviewed changes
Copy link

@xD-saleem xD-saleem left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Ideally, we also add tests that verify the behaviour.
Otherwise looks fine imo.

EDIT: @Darksonn approved it so its fine.

@Noah-Kennedy
Copy link
Contributor Author

@saleemadat @Darksonn This is a draft PR. I am adding #[track_caller] to the whole codebase, then adding tests. This is not finished yet.

This was referenced Jun 16, 2022
Merged
Merged
@Darksonn
Copy link
Contributor

Adding #[track_caller] has been done in a different series of PRs.

@Darksonn Darksonn closed this Aug 10, 2022
@Darksonn Darksonn deleted the noah/track-caller branch August 10, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xD-saleem xD-saleem xD-saleem left review comments

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate R-loom Run loom tests on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

polish: add #[track_caller] to functions that can panic
3 participants
@Noah-Kennedy @Darksonn @xD-saleem