Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: swallow panics in drop(join_handle) #4430

Merged
merged 3 commits into from Jan 28, 2022
Merged

runtime: swallow panics in drop(join_handle) #4430

merged 3 commits into from Jan 28, 2022

Commits on Jan 27, 2022

  1. runtime: swallow panics in drop(join_handle) 

    fixes tokio-rs#4412

From the issue description:

> In Tokio, panics are generally caught and not passed resumed when
dropping the JoinHandle, however when dropping the JoinHandle of a task
that has already completed, that panic can propagate to the user who
dropped the JoinHandle.

This PR fixes that.
    @BraulioVM
    BraulioVM committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    deeb4a2 View commit details
    Browse the repository at this point in the history

  2. explain why we swallow the panic

    @BraulioVM
    BraulioVM committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    2a6072a View commit details
    Browse the repository at this point in the history

  3. improve phrasing of the comment 

    Co-authored-by: Alice Ryhl <aliceryhl@google.com>
    @BraulioVM @Darksonn
    BraulioVM and Darksonn committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    512152b View commit details
    Browse the repository at this point in the history