New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update num_cpus to 1.13.1 to fix cgroup parse problem #4332
Conversation
We typically set Tokio to depend on the oldest version that:
So in this case it is not clear why we should require the new version. People will get the newest version by default even with our current dependency configuration. |
Because the old version has some bug, and the new version fixed the bug. |
Yes, I understand, but with the current configuration, people can still use the new version - in fact, they are getting the new version by default. |
If they use --locked, then they may get the old version. |
The main con is that we prevent users from choosing to use an older version of |
Just an inquiry: so we won't update a version of our dependency for bug fixes? Or in what situation we will update our dependency? |
I think the important thing to note here is that we are talking about increasing the minimum required version of the dependency. We usually only bump the minimum required version in two situations:
Nothing here prevents people from getting the bugfix, and indeed they will get it by default when starting a new project or when they call |
Thanks |
num_cpus prior to 1.13.1 has some bugs parsing cgroup config, this PR updates num_cpus to 1.13.1 to fix it.
For more information, refer to seanmonstar/num_cpus#113.