Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: add watch::Sender::send_modify method #4310

Merged
merged 11 commits into from Feb 22, 2022
Merged

sync: add watch::Sender::send_modify method #4310

merged 11 commits into from Feb 22, 2022

Commits on Dec 10, 2021

  1. sync: add watch::Sender::send_modify method

    @nylonicious
    nylonicious committed Dec 10, 2021
    Copy the full SHA
    d720599 View commit details
    Browse the repository at this point in the history

  2. fix typo

    @nylonicious
    nylonicious committed Dec 10, 2021
    Copy the full SHA
    e1e73da View commit details
    Browse the repository at this point in the history

  3. Include comments from send_replace method

    @nylonicious
    nylonicious committed Dec 10, 2021
    Copy the full SHA
    aeca6b1 View commit details
    Browse the repository at this point in the history

  4. Replace impl of send_replace with call to send_modify

    @nylonicious
    nylonicious committed Dec 10, 2021
    Copy the full SHA
    d629aa4 View commit details
    Browse the repository at this point in the history

  5. Catch and propagate panics inside func to the caller

    @nylonicious
    nylonicious committed Dec 10, 2021
    Copy the full SHA
    02c1a2a View commit details
    Browse the repository at this point in the history

  6. Drop lock before we resume unwinding

    @nylonicious
    nylonicious committed Dec 10, 2021
    Copy the full SHA
    460c3e9 View commit details
    Browse the repository at this point in the history

  7. Sender::send call send_modify instead send_replace

    @nylonicious
    nylonicious committed Dec 10, 2021
    Copy the full SHA
    d1de3e0 View commit details
    Browse the repository at this point in the history

  8. Add test

    @nylonicious
    nylonicious committed Dec 10, 2021
    Copy the full SHA
    dcf9ffc View commit details
    Browse the repository at this point in the history

  9. Document panic behaviour

    @nylonicious
    nylonicious committed Dec 10, 2021
    Copy the full SHA
    b142f96 View commit details
    Browse the repository at this point in the history

  10. Improve documentation and check for value after panic 

    Co-authored-by: Alice Ryhl <alice@ryhl.io>
    @nylonicious @Darksonn
    nylonicious and Darksonn committed Dec 10, 2021
    Copy the full SHA
    69cb652 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. Restore old watch::Sender::send behaviour

    @nylonicious
    nylonicious committed Jan 10, 2022
    Copy the full SHA
    fc551f5 View commit details
    Browse the repository at this point in the history