extend AsyncFdReadyGuard method rettypes lifetimes #4267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The implicit elided lifetimes of the
AsyncFd
references in return types of methods onAsyncFdReadyGuard
resolved to that of&self
, which is needlessly small.Solution
Change the lifetimes of the references. Should not be a breaking change thanks to subtyping.
On a parallel note, I would also like to get an opinion on whether this pull request should be made to include a new
into_try_io()
method onAsyncFdReadyMutGuard
:since the currently existing
try_io()
method is limiting when writing streaming streams, as the result of the closure cannot reference anything that outlives the guard handle. One example where this perhaps would have been useful is in the implementation of thecapture-stream
feature of the pcap crate.