Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare Tokio v1.13.1 #4235

Merged
merged 3 commits into from Nov 15, 2021
Merged

chore: prepare Tokio v1.13.1 #4235

merged 3 commits into from Nov 15, 2021

Commits on Nov 15, 2021

  1. Copy the full SHA
    1774831 View commit details
    Browse the repository at this point in the history
  2. oneshot: document UnsafeCell invariants (#4229)

    Depends on #4226
    
    ## Motivation
    
    Currently, the safety invariants and synchronization strategy used in
    `tokio::sync::oneshot` are not particularly obvious, especially to a new
    reader. It would be nice to better document this code to make these
    invariants clearer.
    
    ## Solution
    
    This branch adds `SAFETY:` comments to the `oneshot` channel
    implementation. In particular, I've focused on documenting the
    invariants around when the inner `UnsafeCell` that stores the value can
    be accessed by the sender and receiver sides of the channel.
    
    I still want to take a closer look at when the waker cells can be set,
    and I'd like to add more documentation there in a follow-up branch.
    
    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    hawkw committed Nov 15, 2021
    Copy the full SHA
    e848018 View commit details
    Browse the repository at this point in the history
  3. chore: prepare Tokio v1.13.1 (#4235)

    # 1.13.1 (November 15, 2021)
    
    ### Fixed
    
    - sync: fix a data race between `oneshot::Sender::send` and awaiting a
      `oneshot::Receiver` when the oneshot has been closed ([#4226])
    
    [#4226]: #4226
    hawkw committed Nov 15, 2021
    Copy the full SHA
    5433119 View commit details
    Browse the repository at this point in the history