Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: add from_std to ChildStd* #4045

Merged
merged 2 commits into from
Aug 19, 2021
Merged

process: add from_std to ChildStd* #4045

merged 2 commits into from
Aug 19, 2021

Conversation

Darksonn
Copy link
Contributor

This is potentially useful if you use another crate to set up the pipes between the children, but that other crate only provides blocking endpoints to their pipes.

Closes: #2837

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-process Module: tokio/process labels Aug 17, 2021
@Darksonn Darksonn requested a review from ipetkov August 17, 2021 14:53
Copy link
Member

@ipetkov ipetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding this!

@Darksonn Darksonn merged commit 2bc9a42 into master Aug 19, 2021
@Darksonn Darksonn deleted the childio-from-std branch August 19, 2021 07:46
@Darksonn Darksonn removed the relnotes label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-process Module: tokio/process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement TryFrom so that std::process:ChildStdxx can be converted to tokio::process:ChildStdxx
2 participants