io: Add (read|write)_f(32|64)[_le] methods #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Aug 4, 2021
The methods (read|write)_f(32|64)[_le] to Async(Read|Write)Ext.
|
@Darksonn Done |
|
Locally it is running without errors and the new test does not fail. |
|
I will look into the CI failure. It appears to be unrelated to your PR, and you don't need to worry about it. I restarted CI. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods (read|write)_f(32|64)[_le] to Async(Read|Write)Ext.
Motivation
Now, it is possible to read and write floating types from an Async(Read|Write) type.
Solution
Add (read|write)_f(32|64)[_le] methods.
Fixes #3435.