Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update async_send_sync test #3943

Merged
merged 2 commits into from Jul 12, 2021
Merged

chore: update async_send_sync test #3943

merged 2 commits into from Jul 12, 2021

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Jul 8, 2021

This updates the async_send_sync.rs test.

@Darksonn Darksonn added the A-tokio Area: The main tokio crate label Jul 8, 2021
Darksonn
Darksonn commented Jul 8, 2021
View reviewed changes
tokio/src/task/task_local.rs
@@ -234,6 +238,8 @@ pin_project! {
slot: Option<T>,
#[pin]
future: F,
#[pin]
_pinned: PhantomPinned,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't do this, then #3273 changes whether TaskLocal::scope returns an Unpin future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch 👍

@carllerche carllerche merged commit 7a11cfd into master Jul 12, 2021
@carllerche carllerche deleted the async-send-sync-refresh branch July 12, 2021 14:38
@BugenZhao BugenZhao mentioned this pull request Jun 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Darksonn @carllerche