Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RwLock guard lock ref recovery methods, owned guards #3930

Closed
wants to merge 1 commit into from

Conversation

ijackson
Copy link
Contributor

@ijackson ijackson commented Jul 6, 2021

Split off from #3928 which is (now) the same thing just for Mutex.

Open questions:

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-sync Module: tokio/sync labels Jul 6, 2021
@Darksonn
Copy link
Contributor

Darksonn commented Jul 6, 2021

Adding a new generic parameter would indeed not be possible. I am inclined to having the method on the mutex type only, similar to what parking_lot does.

@ijackson
Copy link
Contributor Author

ijackson commented Jul 6, 2021

Adding a new generic parameter would indeed not be possible. I am inclined to having the method on the mutex type only, similar to what parking_lot does.

I think having the methods where we can conveniently provide them is better, but of course it's up to you. Please feel free to close this MR if you've decided against having this on only a subset of the rwlock guards. I guess we could always resurrect it if someone else wants them.

@Darksonn
Copy link
Contributor

Closing this for now.

@Darksonn Darksonn closed this Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-sync Module: tokio/sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants