Ucred returns pid field for OpenBSD. #3919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this because it currently does the wrong thing? Can we have a test that catches it? |
|
Not so much but more to address #3102 |
|
Aha, that would be nice to include in the description. |
|
Please push new commits instead of amending your existing commit. It makes it easier for me to see what changed since I last looked. |
|
was mostly stylistic as I do not have rustfmt on my netbsd VM. |
Darksonn
reviewed
Jul 5, 2021
tokio/src/net/unix/ucred.rs
Outdated
Comment on lines
56
to
62
| #[cfg(target_os = "openbsd")] | ||
| use libc::sockpeercred; | ||
| #[cfg(any(target_os = "linux", target_os = "android"))] | ||
| use libc::ucred; | ||
| #[cfg(target_os = "openbsd")] | ||
| #[allow(non_camel_case_types)] | ||
| type ucred = sockpeercred; |
There was a problem hiding this comment.
Suggested change
| #[cfg(target_os = "openbsd")] | |
| use libc::sockpeercred; | |
| #[cfg(any(target_os = "linux", target_os = "android"))] | |
| use libc::ucred; | |
| #[cfg(target_os = "openbsd")] | |
| #[allow(non_camel_case_types)] | |
| type ucred = sockpeercred; | |
| #[cfg(target_os = "openbsd")] | |
| use libc::sockpeercred as ucred; | |
| #[cfg(any(target_os = "linux", target_os = "android"))] | |
| use libc::ucred; |
tokio/src/net/unix/ucred.rs
Outdated
Comment on lines
144
to
145
| } | ||
| #[cfg(any(target_os = "dragonfly", target_os = "freebsd"))] |
There was a problem hiding this comment.
Just inserting a newline here.
Suggested change
| } | |
| #[cfg(any(target_os = "dragonfly", target_os = "freebsd"))] | |
| } | |
| #[cfg(any(target_os = "dragonfly", target_os = "freebsd"))] |
Darksonn
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.