Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: fix time::advance() with sub-ms durations #3852

Merged
merged 7 commits into from Jun 14, 2021
Merged

time: fix time::advance() with sub-ms durations #3852

merged 7 commits into from Jun 14, 2021

Commits on Jun 11, 2021

  1. time: fix time::advance() with sub-ms durations 

    Update the advance logic to factor in the timer's ms rounding.

Fixes #3837
    @carllerche
    carllerche committed Jun 11, 2021
    Copy the full SHA
    98cd6d4 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: sb64 <53383020+sb64@users.noreply.github.com>
    @carllerche @sb64
    carllerche and sb64 committed Jun 11, 2021
    Copy the full SHA
    7b4e5b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. intercept wakes and don't advance time in that case

    @carllerche
    carllerche committed Jun 14, 2021
    Copy the full SHA
    b8bc6b9 View commit details
    Browse the repository at this point in the history

  2. apply suggestions

    @carllerche
    carllerche committed Jun 14, 2021
    Copy the full SHA
    e790b0a View commit details
    Browse the repository at this point in the history

  3. more feedback

    @carllerche
    carllerche committed Jun 14, 2021
    Copy the full SHA
    bbf5f5e View commit details
    Browse the repository at this point in the history

  4. fix build

    @carllerche
    carllerche committed Jun 14, 2021
    Copy the full SHA
    5dd84bb View commit details
    Browse the repository at this point in the history

  5. try to fix the build again

    @carllerche
    carllerche committed Jun 14, 2021
    Copy the full SHA
    f94ebfa View commit details
    Browse the repository at this point in the history