Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: path dependencies for all tokio things #3764

Merged
merged 1 commit into from May 8, 2021

Conversation

udoprog
Copy link
Contributor

@udoprog udoprog commented May 7, 2021

This adds path fragments to all workspace tokio dependencies.

Motivation

If this is not in place, test builds won't pick up now changes from other components. E.g. it's not possible to add an example of something recently added to tokio in examples (root cause of build failure in #3760).

Passes locally so here's to hoping it works in CI. A resolver bump was not needed AFAIU, so there's no MSRV implications.

@udoprog udoprog added the A-examples Area: The examples label May 7, 2021
@udoprog udoprog requested a review from Darksonn May 7, 2021 22:38
@udoprog udoprog added the C-maintenance Category: PRs that clean code up or issues documenting cleanup. label May 7, 2021
@Darksonn Darksonn merged commit 2c5dc83 into tokio-rs:master May 8, 2021
@udoprog udoprog deleted the tokio-path-deps branch May 8, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-examples Area: The examples C-maintenance Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants