Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: RwLock add try_read and try_write methods #3400

Merged
merged 8 commits into from
Jan 14, 2021
Merged

sync: RwLock add try_read and try_write methods #3400

merged 8 commits into from
Jan 14, 2021

Conversation

nylonicious
Copy link
Contributor

Closes #2284

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-sync Module: tokio/sync labels Jan 10, 2021
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. The implementations look good to me. I left a note about the error types.

tokio/src/sync/rwlock.rs Outdated Show resolved Hide resolved
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me — one small docs nit

tokio/src/sync/rwlock.rs Outdated Show resolved Hide resolved
tokio/src/sync/rwlock.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-sync Module: tokio/sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RwLock miss try_read and try_write method
4 participants