Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: remove path deps #3376

Merged
merged 2 commits into from
Jan 4, 2021
Merged

stream: remove path deps #3376

merged 2 commits into from
Jan 4, 2021

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Jan 4, 2021

Follow-up to: #3374

I forgot to remove path deps 馃槄

@Darksonn Darksonn added the A-tokio-stream Area: The tokio-stream crate label Jan 4, 2021
@dekellum
Copy link
Contributor

dekellum commented Jan 4, 2021

Do you really need to remove the path deps? I thought cargo publish ignored these on re-written Cargo.lock?

@Darksonn
Copy link
Contributor Author

Darksonn commented Jan 4, 2021

Maybe not, but doing so will help us catch the case where the crate depends on an yet unpublished feature in its path-dependencies.

@Darksonn Darksonn merged commit 3b840fb into master Jan 4, 2021
@Darksonn Darksonn deleted the prepare-tokio-0.1.1-2 branch January 4, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
A-tokio-stream Area: The tokio-stream crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Darksonn @dekellum @LucioFranco