Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose the Notified future #3372

Closed
wants to merge 1 commit into from
Closed

Conversation

Marwes
Copy link
Contributor

@Marwes Marwes commented Jan 4, 2021

Motivation

I would like to avoid boxing the Notified future when storing it a struct in fede1024/rust-rdkafka#320 .

Solution

Exporting the type allows it to be named

Would let me name the `Notified` future in fede1024/rust-rdkafka#320
instead of boxing it.
@Darksonn Darksonn added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-sync Module: tokio/sync labels Jan 4, 2021
@carllerche
Copy link
Member

carllerche commented Mar 16, 2021

If we do this, we should probably create a future module in sync to avoid populating the sync docs w/ future types. This would match the error module pattern.

@Darksonn
Copy link
Contributor

Closing as duplicate of #3840.

@Darksonn Darksonn closed this May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-sync Module: tokio/sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants