tcp_stream: implement keepalive/set_keepalive #3274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psarna
force-pushed
the
add_keepalive
branch
from
4cc9270
to
f21c512
Compare
In order to restore the ability to set keepalive duration for a TCP stream, a pair of keepalive()/set_keepalive() functions are implemented on top of mio's keepalive feature. Refs tokio-rs#3082
psarna
force-pushed
the
add_keepalive
branch
from
f21c512
to
f875908
Compare
|
Thanks for taking the time to submit this, we decided to punt this for now: #3146. That PR did have some notes on next steps. I would recommend opening an issue w/ a proposed API, and details on portability across platforms. Additionally, it should be possible to set the keepalive from outside of Tokio, so you should not be blocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Setting keepalive parameters used to be possible in previous releases, and it would be nice to restore this capability. Long-standing TCP connections could benefit from having keepalive probes enabled. Example use case: scylladb/scylla-rust-driver#132
Refs #3082
Solution
A pair of keepalive()/set_keepalive() functions are implemented on top of mio's keepalive feature (added in tokio-rs/mio#1385). The interface is consistent with the one from Tokio 0.2.9. This patch comes with a simple test which verifies that previously set values are indeed saved.