Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: remove empty udp module #3260

Merged
merged 1 commit into from
Dec 11, 2020
Merged

net: remove empty udp module #3260

merged 1 commit into from
Dec 11, 2020

Conversation

leshow
Copy link
Contributor

@leshow leshow commented Dec 11, 2020 •
edited

closes #2989

is this alright? I removed udp/mod.rs and the dir, moving everything into net/udp.rs

LucioFranco
LucioFranco approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LucioFranco
Copy link
Member

Yeah, Don't think its a breaking change to move it back to a mod in the future.

@LucioFranco LucioFranco merged commit 68717c7 into tokio-rs:master Dec 11, 2020
@Darksonn Darksonn added A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-net Module: tokio/net labels Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-net Module: tokio/net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The tokio::net::udp module is empty
3 participants
@leshow @LucioFranco @Darksonn