Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: prepare v0.5.1 release #3210

Merged
merged 4 commits into from
Dec 3, 2020
Merged

util: prepare v0.5.1 release #3210

merged 4 commits into from
Dec 3, 2020

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Dec 3, 2020

Added

@hawkw
util: prepare v0.5.1 release
ef6b157 
Added

- io: `poll_read_buf` util fn (#2972).
- io: `poll_write_buf` util fn with vectored write support (#3156).
@hawkw hawkw added A-tokio-util Area: The tokio-util crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. labels Dec 3, 2020
@hawkw hawkw requested a review from carllerche December 3, 2020 21:05
@hawkw hawkw self-assigned this Dec 3, 2020
Darksonn
Darksonn approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to remove a path dependency.

@hawkw
rm path dep
59b4d27 
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw
fix cargo.toml parse error
7441640 
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw
Copy link
Member Author

hawkw commented Dec 3, 2020 •
edited

@Darksonn

You might need to remove a path dependency.

Hmm, not sure if that's the case --- the examples that use both tokio and tokio-util no longer compile with the path dep removed. Without the path dep, tokio-util depends on a different version of tokio (the crates.io version) than the examples themselves do (a path dep), and the traits don't line up (see https://github.com/tokio-rs/tokio/runs/1495659254)

I believe cargo just ignores path deps when publishing?

@hawkw
Revert path dep removal
0d623d0 
This reverts commits 59b4d27 and
7441640. It turns out that the path
dependencies are actually load-bearing; the examples don't compile
without them.
@hawkw hawkw merged commit 00500d1 into master Dec 3, 2020
@hawkw hawkw deleted the eliza/tokio-util-0.5.1 branch December 3, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

@carllerche carllerche Awaiting requested review from carllerche

Assignees

@hawkw hawkw

Labels
A-tokio-util Area: The tokio-util crate C-maintenance Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hawkw @Darksonn