Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tokio02-style mpsc sender #3105
Add tokio02-style mpsc sender #3105
Changes from 1 commit
e29745b
87ab07e
08fac61
1bf5598
f3b06ae
19df42a
6c85b54
528ace5
ac896ab
deff81e
cbbfaf0
1757368
8077de6
6c976f6
ffaa112
eae5db6
b4359ee
8ca1ea6
6e8d488
20394f6
613024d
f3a2975
9a7c0b4
d89a4ea
d3088c1
cc72b31
0eb2c49
3f59124
718a844
49c8b60
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This boxing can be avoided when
type_alias_impl_trait
finally lands.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, if this was implemented in
tokio
rather than intokio-util
, this could just use the internal semaphore implementation'sAcquire
future. But, I don't think that's going to ever become public API, so this would need to be intokio
proper.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that cancellation token tests are just ignored currently.