util: resurrect UdpFramed #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio-util
taiki-e
reviewed
Oct 27, 2020
leshow
force-pushed
the
resurrect_udp_framed
branch
from
4f11045
to
96a4c74
Compare
Darksonn
reviewed
Oct 27, 2020
leshow
force-pushed
the
resurrect_udp_framed
branch
from
2433aba
to
1e5113d
Compare
Darksonn
reviewed
Nov 1, 2020
Darksonn
approved these changes
Nov 1, 2020
leshow
force-pushed
the
resurrect_udp_framed
branch
from
0305589
to
fc4be61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Brings back
UdpFramedintokio-util. This was the only way to create aStream/Sinkfrom aUdpSocketusingDecoder/Encoderso I think it's important to have.In earlier commits I had also brought back
splitforUdpSocketbut I've removed that for now. I wanted a way tosplitonUdpFramedalso and get an independentStream/Sink, but there's no way to share theCodecamong both sides that I can see, since they both require&mutaccess. So for now, just bringing backUdpFramedSolution
Mostly just un-commenting what was there with some small modifications due to
ReadBufI think this closes out #2830 , we've added back
poll_*functions forUdpSocketandUdpFramed