Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io: Rename ReadBuf methods #2945

Merged
merged 1 commit into from Oct 12, 2020
Merged

io: Rename ReadBuf methods #2945

merged 1 commit into from Oct 12, 2020

Conversation

LucioFranco
Copy link
Member

This changes ReadBuf::add_filled to ReadBuf::advance and
ReadBuf::append to ReadBuf::put_slice. This is just a
mechanical change.

Closes #2769

This changes `ReadBuf::add_filled` to `ReadBuf::advance` and
`ReadBuf::append` to `ReadBuf::put_slice`. This is just a
mechanical change.

Closes #2769
@Darksonn Darksonn added A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-io Module: tokio/io labels Oct 12, 2020
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this rename is good 👍

@LucioFranco LucioFranco merged commit f8c91f2 into master Oct 12, 2020
@LucioFranco LucioFranco deleted the lucio/readbuf-rename branch October 12, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-io Module: tokio/io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

io: remaining AsyncRead / ReadBuf items
2 participants