sync: change chan closed(&mut self) to closed(&self)
#2939
Conversation
| pub(crate) async fn closed(&mut self) { | ||
| pub(crate) async fn closed(&self) { | ||
| use std::future::Future; | ||
| use std::pin::Pin; | ||
| use std::task::Poll; |
There was a problem hiding this comment.
I don't know enough about the internals of channels to know whether it relies on the exclusivity of a mutable reference. However if so, we do not have any loom tests that would catch it, because such a test would not compile before this change was applied.
I would like to see a loom test that calls send and closed on the same Arc<Sender> from multiple threads concurrently.
There was a problem hiding this comment.
@Darksonn Good point! I will verify that.
There was a problem hiding this comment.
Seems these are simply awaiting on a Notify so there should not be much of a problem, but still there is the loom test
There was a problem hiding this comment.
I would assume the &mut self requirement (if there was one) would come from the self.closed call but that seems to take &self so this should be fine.
LucioFranco
changed the title
closed(&mut self) -> closed(&self)closed(&mut self) to closed(&self)
Changes
UnboundedSender::closedandSender::closedto not takeselfasmutRefs: #2928