Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io: make Seek and Copy private #2935

Merged
merged 4 commits into from Oct 9, 2020
Merged

io: make Seek and Copy private #2935

merged 4 commits into from Oct 9, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Oct 9, 2020 •
edited

Motivation

Refs: #2928

Also, this makes io::copy async function.

Solution

@taiki-e taiki-e mentioned this pull request Oct 9, 2020
Closed
21 tasks
@taiki-e taiki-e added A-tokio Area: The main tokio crate M-io Module: tokio/io labels Oct 9, 2020
@Darksonn
Copy link
Contributor

Darksonn commented Oct 9, 2020

It seems like the tokio::io::copy function could just be marked async directly?

@carllerche carllerche merged commit 41ac1ae into tokio-rs:master Oct 9, 2020
@taiki-e taiki-e deleted the io-seek-copy branch October 9, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-io Module: tokio/io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taiki-e @Darksonn @carllerche