Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: switch socket methods to &self #2934

Merged
merged 3 commits into from Oct 9, 2020
Merged

net: switch socket methods to &self #2934

merged 3 commits into from Oct 9, 2020

Conversation

carllerche
Copy link
Member

Switches various socket methods from &mut self to &self. This uses the intrusive
waker infrastructure to handle multiple waiters.

Refs: #2928

taiki-e
taiki-e approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from &mut self argument of UnixListener::accept.

@taiki-e taiki-e mentioned this pull request Oct 9, 2020
Closed
21 tasks
@taiki-e taiki-e added A-tokio Area: The main tokio crate M-net Module: tokio/net labels Oct 9, 2020
carllerche and others added 2 commits October 9, 2020 08:30
@carllerche @taiki-e
Update tokio/src/net/unix/listener.rs
6d201f3 
Co-authored-by: Taiki Endo <te316e89@gmail.com>
@carllerche
fix warnings
28ae533
@carllerche carllerche merged commit ee59734 into master Oct 9, 2020
@carllerche carllerche deleted the fix-net-sigs branch October 9, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-net Module: tokio/net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carllerche @Darksonn @taiki-e