Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: rename Delay future to Sleep #2932

Merged
merged 1 commit into from Oct 9, 2020
Merged

time: rename Delay future to Sleep #2932

merged 1 commit into from Oct 9, 2020

Conversation

alce
Copy link
Member

@alce alce commented Oct 8, 2020 •
edited

Most usages of, and references to delay and Delay are also removed from docs, tests and comments, except for places where I believe it makes sense to keep referring to instances of Sleep as delays.

Examples of this are time::Interval, time::Timeout and stream::Throttle. DelayQueue also remains mostly unchanged.

follow-up to #2826, part of #2928

carllerche
carllerche approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@carllerche carllerche merged commit 60d81bb into tokio-rs:master Oct 9, 2020
@taiki-e taiki-e mentioned this pull request Oct 9, 2020
Closed
21 tasks
@Darksonn Darksonn added A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-time Module: tokio/time labels Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-time Module: tokio/time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alce @carllerche @Darksonn