Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: future proof File #2930

Merged
merged 3 commits into from Oct 9, 2020
Merged

fs: future proof File #2930

merged 3 commits into from Oct 9, 2020

Commits on Oct 8, 2020

  1. fs: future proof File 

    Changes inherent methods to take `&self` instead of `&mut self`. This
brings the API in line with `std`.

This patch is implemented by using a `tokio::sync::Mutex` to guard the
internal `File` state. This is not an ideal implementation strategy
doesn't make a big impact compared to having to dispatch operations to a
background thread followed by a blocking syscall.

In the future, the implementation can be improved as we explore async
file-system APIs provided by the operating-system (iocp / io_uring).

Closes #2927
    @carllerche
    carllerche committed Oct 8, 2020
    Copy the full SHA
    12bba6f View commit details
    Browse the repository at this point in the history

  2. fmt

    @carllerche
    carllerche committed Oct 8, 2020
    Copy the full SHA
    52579f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. Merge remote-tracking branch 'origin/master' into intrusive-fs

    @carllerche
    carllerche committed Oct 9, 2020
    Copy the full SHA
    1d7c48d View commit details
    Browse the repository at this point in the history