Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: make Child::kill async #2823

Merged
merged 2 commits into from Sep 8, 2020
Merged

process: make Child::kill async #2823

merged 2 commits into from Sep 8, 2020

Commits on Sep 7, 2020

  1. process: make Child::kill async 

    * This changes the `Child::kill` to be an async method which awaits the
  child after sending a kill signal. This avoids leaving zombie
  processes on Unix platforms if the caller forgets to await the child
  after the kill completes
* A `start_kill` method was also added on `Child` which only sends the
  kill signal to the child process. This allows for kill signals to be
  sent even outside of async contexts.
    @ipetkov
    ipetkov committed Sep 7, 2020
    Copy the full SHA
    a01a87a View commit details
    Browse the repository at this point in the history

  2. Update tokio/src/process/mod.rs 

    Co-authored-by: Alice Ryhl <alice@ryhl.io>
    @ipetkov @Darksonn
    ipetkov and Darksonn committed Sep 7, 2020
    Copy the full SHA
    816ef91 View commit details
    Browse the repository at this point in the history