Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io: add ReadBuf::take #2817

Merged
merged 1 commit into from Sep 5, 2020
Merged

io: add ReadBuf::take #2817

merged 1 commit into from Sep 5, 2020

Conversation

zaharidichev
Copy link
Contributor

Motivation

There was a comment indicating that extracing some login into ReadBuf::take is a good idea.

Signed-off-by: Zahari Dichev zaharidichev@gmail.com

@zaharidichev
io: add ReadBuf::take
de565fd 
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
@Darksonn Darksonn added A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-io Module: tokio/io labels Sep 5, 2020
Darksonn
Darksonn approved these changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable.

I think in general it would be nice to improve the documentation here, but this applies to a lot of the methods on ReadBuf, and can be done on another PR.

@carllerche carllerche merged commit 171cb57 into tokio-rs:master Sep 5, 2020
@Darksonn Darksonn mentioned this pull request Oct 5, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

@carllerche carllerche Awaiting requested review from carllerche

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-io Module: tokio/io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zaharidichev @Darksonn @carllerche