Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: tweak watch API #2814

Merged
merged 5 commits into from Sep 11, 2020
Merged

sync: tweak watch API #2814

merged 5 commits into from Sep 11, 2020

Commits on Sep 4, 2020

  1. sync: tweak watch API 

    Decouples getting the latest `watch` value from receiving the change
notification. The `Receiver` async method becomes
`Receiver::changed()`. The latest value is obtained from
`Receiver::borrow()`.

The implementation is updated to use `Notify`. This requires adding
`Notify::notify_waiters`. This method is generally useful but is kept
private for now.
    @carllerche
    carllerche committed Sep 4, 2020
    Copy the full SHA
    a3e59ff View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Eliza Weisman <eliza@buoyant.io>
    @carllerche @hawkw
    carllerche and hawkw committed Sep 9, 2020
    Copy the full SHA
    f377f03 View commit details
    Browse the repository at this point in the history

  2. reduce the scope of the write lock

    @carllerche
    carllerche committed Sep 9, 2020
    Copy the full SHA
    b8b0693 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. fix bugs

    @carllerche
    carllerche committed Sep 11, 2020
    Copy the full SHA
    3437fb4 View commit details
    Browse the repository at this point in the history

  2. fmt

    @carllerche
    carllerche committed Sep 11, 2020
    Copy the full SHA
    762d48b View commit details
    Browse the repository at this point in the history