Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: fix panic when dropping LocalSet #1843

Merged
merged 2 commits into from Nov 27, 2019
Merged

task: fix panic when dropping LocalSet #1843

merged 2 commits into from Nov 27, 2019

Commits on Nov 27, 2019

  1. add test to reproduce #1842 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Nov 27, 2019
    Copy the full SHA
    0637bc6 View commit details
    Browse the repository at this point in the history

  2. task: fix panic when dropping LocalSet 

    it turns out that the `Scheduler::release` method on `LocalSet`'s
`Scheduler` *is* called, when the  `Scheduler` is dropped with tasks
still running. Currently, that method is `unreachable!`, which means
that dropping a `LocalSet` with tasks running will panic.

This commit fixes the panic, by pushing released tasks to
`pending_drop`. This is the same as `BasicScheduler`.

Fixes #1842

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Nov 27, 2019
    Copy the full SHA
    5641a5e View commit details
    Browse the repository at this point in the history