Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ucred for illumos/solaris #1772

Merged
merged 1 commit into from Nov 27, 2019
Merged

Conversation

papertigers
Copy link
Contributor

Fixes an incorrect import.

In order to run the test suite successfully on illumos I had to modify

However, once I patched those via [patchs.crates-io] in the workspace the test suite runs to completion with:

test result: ok. 129 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out

@papertigers
Copy link
Contributor Author

The PR for the mio-uds fix is at deprecrated/mio-uds/pull/26

@papertigers
Copy link
Contributor Author

Bump.
Bummer this missed the tokio 0.2.0 release.

@carllerche
Copy link
Member

Do you have any thoughts on how to get illumos / solaris CI?

@carllerche carllerche merged commit 34d751b into tokio-rs:master Nov 27, 2019
@papertigers
Copy link
Contributor Author

I don't because azure pipelines and other's only seem to offer mostly windows/linux VMs. We use jenkins internally for illumos CI.

One of the main gaps we are trying to close right now is getting an official illumos rust target so that we can also get rustup in the process.

@carllerche
Copy link
Member

Doesn’t azure support bringing your own hardware? If so, could we integrate a Solaris box in the process somehow?

@papertigers
Copy link
Contributor Author

@carllerche for azure pipelines? When I looked at the docs it seemed that they only offered a few specific VM flavors. Do they support bringing your own hardware? I am interested in figuring out how we can get to a CI solution in general for illumos, but can't speak much for the solaris side of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants