v0.1.x: stage -threadpool 0.1.16 -reactor 0.1.10 releases #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use std RandomState for XorShift seeding. This allows dropping _rand_ crate dep here, accept as a dev dependency for tests or benchmarks.
But avoid tempfile 3.2 for now, since history demonstrates it bumps rand versions and MSRV in MINOR updates.
|
@LucioFranco this is ready, I believe, with everything needed before |
LucioFranco
approved these changes
Sep 25, 2019
|
I'd like to get a second review from carl then I think we can publish this! Thanks! |
|
@carllerche? From last comments of #1358 it sounded like this was already pretty much decided upon? |
|
@dekellum yup! sorry been busy, I am gonna push this out today. Thank you for all the work, we all very VERY much appreciate it! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges #1358 to current v0.1.x branch, firstly just to make sure CI is still passing.
In ad62407, it also bumps the env_logger dev dependency to 0.6. (env_logger 0.7 was releases only two days ago, so 0.6.2 is considered a more conservative choice.) This is just a backport of #1390 (on master).
I plan to make the version bumps and CHANGELOG entries here as well, after confirming CI on the base changes.