Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the atomic u64 mock is properly tested #5358

Closed
Darksonn opened this issue Jan 6, 2023 · 0 comments · Fixed by #5374
Closed

Ensure that the atomic u64 mock is properly tested #5358

Darksonn opened this issue Jan 6, 2023 · 0 comments · Fixed by #5374
Assignees
@taiki-e
Labels
A-ci Area: The continuous integration setup E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@Darksonn
Copy link
Contributor

Darksonn commented Jan 6, 2023

We had this failure that we didn't catch: #5356. A new CI step should be added that would have caught this mistake.
@Darksonn Darksonn added A-ci Area: The continuous integration setup E-help-wanted Call for participation: Help is requested to fix this issue. labels Jan 6, 2023
@taiki-e taiki-e self-assigned this Jan 13, 2023
@taiki-e taiki-e mentioned this issue Jan 13, 2023
Merged
carllerche pushed a commit that referenced this issue Jan 14, 2023
@taiki-e
tokio: fix remaining issues about atomic_u64_static_once_cell.rs (#5374)
40782ef 
Fixes #5373
Closes #5358 

- Add check for no_atomic_u64 & no_const_mutex_new (condition to atomic_u64_static_once_cell.rs is compiled)
- Allow unused_imports in TARGET_ATOMIC_U64_PROBE. I also tested other *_PROBE and found no other errors triggered by -D warning.
- Fix cfg of util::once_cell module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taiki-e taiki-e

Labels
A-ci Area: The continuous integration setup E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tokio: fix remaining issues about atomic_u64_static_once_cell.rs tokio-rs/tokio
2 participants
@Darksonn @taiki-e