Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: RwLock add try_read and try_write methods #3400

Merged
merged 8 commits into from Jan 14, 2021
Merged

sync: RwLock add try_read and try_write methods #3400

merged 8 commits into from Jan 14, 2021

Conversation

nylonicious
Copy link
Contributor

Closes #2284

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-sync Module: tokio/sync labels Jan 10, 2021
carllerche
carllerche requested changes Jan 12, 2021
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. The implementations look good to me. I left a note about the error types.

tokio/src/sync/rwlock.rs Outdated Show resolved Hide resolved
carllerche
carllerche approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

hawkw
hawkw approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me — one small docs nit

tokio/src/sync/rwlock.rs Outdated Show resolved Hide resolved
tokio/src/sync/rwlock.rs Outdated Show resolved Hide resolved
@hawkw hawkw merged commit ecc32d1 into tokio-rs:master Jan 14, 2021
@nylonicious nylonicious deleted the rwlock_try branch January 15, 2021 08:06
@Darksonn Darksonn mentioned this pull request Jan 22, 2021
Merged
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-sync Module: tokio/sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RwLock miss try_read and try_write method
4 participants
@nylonicious @carllerche @hawkw @Darksonn