Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tokio::net::udp module is empty #2989

Closed
Darksonn opened this issue Oct 19, 2020 · 5 comments · Fixed by #3260
Closed

The tokio::net::udp module is empty #2989

Darksonn opened this issue Oct 19, 2020 · 5 comments · Fixed by #3260
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. M-net Module: tokio/net
Milestone

Comments

@Darksonn
Copy link
Contributor

The tokio::net::udp module is empty. Unless we add something to it during 0.3, we should remove it for 1.0.

@Darksonn Darksonn added C-maintenance Category: PRs that clean code up or issues documenting cleanup. A-tokio Area: The main tokio crate M-net Module: tokio/net labels Oct 19, 2020
@Darksonn Darksonn added this to the v1.0 milestone Oct 19, 2020
@sstelfox
Copy link

The contents are currently commented out pending the results of #2830. I'd personally like to see tokio include first class UDP support in the v1.0 milestone

@leshow
Copy link
Contributor

leshow commented Oct 22, 2020

edit: Wow, sorry, I misunderstood the comment to be about tokio-util. AFAIK OwnedReadHalf OwnedWriteHalf etc are not necessary for UdpSocket because you can just Arc it and be on your way?

@LucioFranco
Copy link
Member

Okay I think the right approach here is to pub(crate) the udp module and to bring it back in later iterations. We likely can put most of the things in there into tokio_util::udp.

@Darksonn
Copy link
Contributor Author

Yeah, just remove the module for now. We can add it back if we added read and write halfs or some other udp utility.

@Darksonn Darksonn added E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. labels Dec 10, 2020
@leshow
Copy link
Contributor

leshow commented Dec 11, 2020

I had a branch that added the read/write halves but removed it because you can just use Arc. If you want to include the read/write halves anyway though, let me know and I can polish it up. In the meantime I can remove the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. M-net Module: tokio/net
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants