Skip to content

Commit

Permalink
Fix TokioContext compile issues
Browse files Browse the repository at this point in the history
  • Loading branch information
LucioFranco committed Aug 27, 2020
1 parent 9f1e156 commit dd7fc15
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 13 deletions.
13 changes: 6 additions & 7 deletions tokio-util/src/context.rs
Expand Up @@ -12,7 +12,7 @@ use std::{
pin::Pin,
task::{Context, Poll},
};
use tokio::runtime::Handle;
use tokio::runtime::Runtime;

pin_project! {
/// `TokioContext` allows connecting a custom executor with the tokio runtime.
Expand All @@ -22,7 +22,7 @@ pin_project! {
pub struct TokioContext<F> {
#[pin]
inner: F,
handle: Handle,
handle: Runtime,
}
}

Expand All @@ -39,16 +39,16 @@ impl<F: Future> Future for TokioContext<F> {
}

/// Trait extension that simplifies bundling a `Handle` with a `Future`.
pub trait HandleExt {
pub trait RuntimeExt {
/// Convenience method that takes a Future and returns a `TokioContext`.
///
/// # Example: calling Tokio Runtime from a custom ThreadPool
///
/// ```no_run
/// use tokio_util::context::HandleExt;
/// use tokio_util::context::RuntimeExt;
/// use tokio::time::{delay_for, Duration};
///
/// let mut rt = tokio::runtime::Builder::new()
/// let rt = tokio::runtime::Builder::new()
/// .threaded_scheduler()
/// .enable_all()
/// .build().unwrap();
Expand All @@ -61,14 +61,13 @@ pub trait HandleExt {
///
/// rt.block_on(
/// rt2
/// .handle()
/// .wrap(async { delay_for(Duration::from_millis(2)).await }),
/// );
///```
fn wrap<F: Future>(&self, fut: F) -> TokioContext<F>;
}

impl HandleExt for Handle {
impl RuntimeExt for Runtime {
fn wrap<F: Future>(&self, fut: F) -> TokioContext<F> {
TokioContext {
inner: fut,
Expand Down
9 changes: 3 additions & 6 deletions tokio-util/tests/context.rs
Expand Up @@ -2,11 +2,11 @@

use tokio::runtime::Builder;
use tokio::time::*;
use tokio_util::context::HandleExt;
use tokio_util::context::RuntimeExt;

#[test]
fn tokio_context_with_another_runtime() {
let mut rt1 = Builder::new()
let rt1 = Builder::new()
.threaded_scheduler()
.core_threads(1)
// no timer!
Expand All @@ -21,8 +21,5 @@ fn tokio_context_with_another_runtime() {

// Without the `HandleExt.wrap()` there would be a panic because there is
// no timer running, since it would be referencing runtime r1.
let _ = rt1.block_on(
rt2.handle()
.wrap(async move { delay_for(Duration::from_millis(2)).await }),
);
let _ = rt1.block_on(rt2.wrap(async move { delay_for(Duration::from_millis(2)).await }));
}

0 comments on commit dd7fc15

Please sign in to comment.