lint: enable unexpected cfg checking in all in-repo builds

.github/workflows/ci.yml

@@ -995,23 +995,6 @@ jobs:
         run: cargo check-external-types --all-features
         working-directory: tokio
 
-  check-unexpected-lints-cfgs:
-    name: check unexpected lints and cfgs
-    needs: basics
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - name: Install Rust ${{ env.rust_nightly }}
-        uses: dtolnay/rust-toolchain@master
-        with:
-          toolchain: ${{ env.rust_nightly }}
-      - name: don't allow warnings
-        run: sed -i '/#!\[allow(unknown_lints, unexpected_cfgs)\]/d' */src/lib.rs */tests/*.rs
-      - name: check for unknown lints and cfgs
-        run: cargo check --all-features --tests
-        env:
-          RUSTFLAGS: -Dwarnings --check-cfg=cfg(loom,tokio_unstable,tokio_taskdump,fuzzing,mio_unsupported_force_poll_poll,tokio_internal_mt_counters,fs,tokio_no_parking_lot,tokio_no_tuning_tests) -Funexpected_cfgs -Funknown_lints
-
   check-fuzzing:
     name: check-fuzzing
     needs: basics

tokio-macros/src/lib.rs

@@ -1,4 +1,3 @@
-#![allow(unknown_lints, unexpected_cfgs)]
 #![allow(clippy::needless_doctest_main)]
 #![warn(
     missing_debug_implementations,

tokio-stream/Cargo.toml

@@ -15,6 +15,7 @@ description = """
 Utilities to work with `Stream` and `tokio`.
 """
 categories = ["asynchronous"]
+exclude = ["build.rs"]
 
 [features]
 default = ["time"]

tokio-stream/build.rs

@@ -0,0 +1,7 @@
+fn main() {
+    // Warning: build.rs is not published to crates.io.
+
+    println!("cargo:rustc-cfg=check_cfg");
+    println!("cargo:rustc-check-cfg=cfg(check_cfg)");
+    println!("cargo:rustc-check-cfg=cfg(loom)");
+}

tokio-stream/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![allow(
     clippy::cognitive_complexity,
     clippy::large_enum_variant,

tokio-test/Cargo.toml

@@ -15,6 +15,7 @@ description = """
 Testing utilities for Tokio- and futures-based code
 """
 categories = ["asynchronous", "development-tools::testing"]
+exclude = ["build.rs"]
 
 [dependencies]
 tokio = { version = "1.2.0", path = "../tokio", features = ["rt", "sync", "time", "test-util"] }

tokio-test/build.rs

@@ -0,0 +1,7 @@
+fn main() {
+    // Warning: build.rs is not published to crates.io.
+
+    println!("cargo:rustc-cfg=check_cfg");
+    println!("cargo:rustc-check-cfg=cfg(check_cfg)");
+    println!("cargo:rustc-check-cfg=cfg(loom)");
+}

tokio-test/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![warn(
     missing_debug_implementations,
     missing_docs,

tokio-util/Cargo.toml

@@ -15,6 +15,7 @@ description = """
 Additional utilities for working with Tokio.
 """
 categories = ["asynchronous"]
+exclude = ["build.rs"]
 
 [features]
 # No features on by default

tokio-util/build.rs

@@ -0,0 +1,8 @@
+fn main() {
+    // Warning: build.rs is not published to crates.io.
+
+    println!("cargo:rustc-cfg=check_cfg");
+    println!("cargo:rustc-check-cfg=cfg(check_cfg)");
+    println!("cargo:rustc-check-cfg=cfg(loom)");
+    println!("cargo:rustc-check-cfg=cfg(tokio_unstable)");
+}

tokio-util/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![allow(clippy::needless_doctest_main)]
 #![warn(
     missing_debug_implementations,

tokio-util/tests/task_join_map.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![warn(rust_2018_idioms)]
 #![cfg(all(feature = "rt", tokio_unstable))]
 

tokio/Cargo.toml

@@ -20,6 +20,7 @@ backed applications.
 """
 categories = ["asynchronous", "network-programming"]
 keywords = ["io", "async", "non-blocking", "futures"]
+exclude = ["build.rs"]
 
 [features]
 # Include nothing by default

tokio/build.rs

@@ -0,0 +1,15 @@
+fn main() {
+    // Warning: build.rs is not published to crates.io.
+
+    println!("cargo:rustc-cfg=check_cfg");
+    println!("cargo:rustc-check-cfg=cfg(check_cfg)");
+    println!("cargo:rustc-check-cfg=cfg(fs)");
+    println!("cargo:rustc-check-cfg=cfg(fuzzing)");
+    println!("cargo:rustc-check-cfg=cfg(loom)");
+    println!("cargo:rustc-check-cfg=cfg(mio_unsupported_force_poll_poll)");
+    println!("cargo:rustc-check-cfg=cfg(tokio_internal_mt_counters)");
+    println!("cargo:rustc-check-cfg=cfg(tokio_no_parking_lot)");
+    println!("cargo:rustc-check-cfg=cfg(tokio_no_tuning_tests)");
+    println!("cargo:rustc-check-cfg=cfg(tokio_taskdump)");
+    println!("cargo:rustc-check-cfg=cfg(tokio_unstable)");
+}

tokio/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![allow(
     clippy::cognitive_complexity,
     clippy::large_enum_variant,

tokio/tests/_require_full.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 
 #[cfg(not(any(feature = "full", target_family = "wasm")))]
 compile_error!("run main Tokio tests with `--features full`");

tokio/tests/dump.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![cfg(all(
     tokio_unstable,
     tokio_taskdump,

tokio/tests/macros_select.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![cfg(feature = "macros")]
 #![allow(clippy::disallowed_names)]
 

tokio/tests/rt_basic.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![warn(rust_2018_idioms)]
 #![cfg(feature = "full")]
 

tokio/tests/rt_common.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![allow(clippy::needless_range_loop)]
 #![warn(rust_2018_idioms)]
 #![cfg(feature = "full")]

tokio/tests/rt_handle.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![warn(rust_2018_idioms)]
 #![cfg(feature = "full")]
 

tokio/tests/rt_metrics.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![warn(rust_2018_idioms)]
 #![cfg(all(feature = "full", tokio_unstable, not(target_os = "wasi")))]
 

tokio/tests/rt_threaded.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![warn(rust_2018_idioms)]
 #![cfg(all(feature = "full", not(target_os = "wasi")))]
 

tokio/tests/rt_threaded_alt.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![warn(rust_2018_idioms)]
 #![cfg(all(feature = "full", not(target_os = "wasi")))]
 #![cfg(tokio_unstable)]

tokio/tests/task_builder.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![cfg(all(tokio_unstable, feature = "tracing"))]
 
 use std::rc::Rc;

tokio/tests/task_id.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![warn(rust_2018_idioms)]
 #![cfg(all(feature = "full", tokio_unstable))]
 

tokio/tests/task_join_set.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![warn(rust_2018_idioms)]
 #![cfg(feature = "full")]
 

tokio/tests/task_local_set.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![warn(rust_2018_idioms)]
 #![cfg(feature = "full")]
 

tokio/tests/task_yield_now.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, unexpected_cfgs)]
+#![cfg_attr(not(check_cfg), allow(unknown_lints, unexpected_cfgs))]
 #![cfg(all(feature = "full", tokio_unstable))]
 
 use tokio::task;