Add steal_operations metric #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bumping the required tokio version is fine. |
jschwe
force-pushed
the
steal_operations2
branch
from
3102187
to
277eca4
Compare
Expose the new `steal_operations` metric which tracks what was previously documented to be `steal_count`.
jschwe
force-pushed
the
steal_operations2
branch
from
277eca4
to
410e7e1
Compare
Noah-Kennedy
approved these changes
Mar 6, 2023
Noah-Kennedy
reviewed
Mar 6, 2023
| @@ -31,7 +31,7 @@ futures = "0.3.21" | |||
| num_cpus = "1.13.1" | |||
| serde = { version = "1.0.136", features = ["derive"] } | |||
| serde_json = "1.0.79" | |||
| tokio = { version = "1.15.0", features = ["full", "rt", "time", "macros", "test-util"] } | |||
| tokio = { version = "1.26.0", features = ["full", "rt", "time", "macros", "test-util"] } | |||
There was a problem hiding this comment.
Not sure why this change is here. This was already set. I wonder if GitHub's viewer is bugged?
There was a problem hiding this comment.
This one was for the dev-dependency.
Merged
Noah-Kennedy
added a commit
that referenced
this pull request
Mar 6, 2023
# 0.2.0 (March 6th, 2023) ### Added - Add `Debug` implementations. ([#28]) - rt: add concrete `RuntimeIntervals` iterator type ([#26]) - rt: add budget_forced_yield_count metric ([#39]) - rt: add io_driver_ready_count metric ([#40]) - rt: add steal_operations metric ([#37]) - task: also instrument streams ([#31]) ### Documented - doc: fix count in `TaskMonitor` docstring ([#24]) - doc: the description of steal_count ([#35]) [#24]: #24 [#26]: #26 [#28]: #28 [#31]: #31 [#35]: #35 [#37]: #37 [#39]: #39 [#40]: #40
jschwe
added a commit
to jschwe/tokio-metrics
that referenced
this pull request
Apr 13, 2023
Follow-up to tokio-rs#35. The new metric is available starting with tokio v1.25.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #35.
The new metric is available starting with tokio v1.25.0.
Would it be okay to just bump the required tokio version and release a new tokio-metrics version? Or would you prefer something more advanced like version detection in a build script?
Edit: A different PR bumped the required tokio version already. Rebased.