Revert "build: Skip empty protobuf files (#605)" #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
added a commit
that referenced
this pull request
May 4, 2022
jgraettinger
added a commit
to estuary/flow
that referenced
this pull request
May 23, 2022
Since its reversion of a commit which omits empty files: tokio-rs/prost#639
jgraettinger
added a commit
to estuary/flow
that referenced
this pull request
May 23, 2022
Since its reversion of a commit which omits empty files: tokio-rs/prost#639
|
I'm a little confused by this, reading hyperium/tonic#964 it seems like the issue is that if someone is specifying I mainly ask because I'm adding workarounds for the empty files, and it would be nice to not need to apache/arrow-rs#2005 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c577d3f.
Fixes hyperium/tonic#964