New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workspace package metadata #1036
base: master
Are you sure you want to change the base?
Conversation
eab9457
to
b11461a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Please rebase as #1033 is merged.
@@ -6,7 +6,7 @@ license.workspace = true | |||
repository.workspace = true | |||
readme = "README.md" | |||
description.workspace = true | |||
edition = "2021" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should only centralize values that are the same for all crates. It can be confusing when the edition is set at the workspace level, but different for other crates.
So we should update the edition of the other crates before doing this commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate PR: #1039
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the private projects have the same edition, then can also use the workspace.edition
.
b11461a
to
50871f3
Compare
50871f3
to
a234ba4
Compare
a234ba4
to
2b8f3a3
Compare
Depends on #1033(merged into master and rebased here)