Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated work arounds #1741

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Remove outdated work arounds #1741

merged 4 commits into from
Dec 14, 2023

Conversation

Thomasdezeeuw
Copy link
Collaborator

Removes two work arounds for OSs versions we don't support any more.

Closes #1561

It's now defined in the libc crate.
Only affected Linux kernels < 2.6.37, which Rust doesn't support any
more.
This was introduces in Linux Linux 2.6.27, glibc 2.9 and Android API
level 21.

Since both are equal or lower than our supported versions we don't need
this fallback any longer.
@Darksonn
Copy link
Contributor

Is Android API level 21 unsupported?

@Thomasdezeeuw
Copy link
Collaborator Author

Is Android API level 21 unsupported?

No it's supported.

The EPOLL_CLOEXEC not being defined isn't really an issue that affects us since the libc crate does define the constant. According to android/ndk#394 (comment) and https://android.googlesource.com/platform/bionic/+/master/libc/libc.map.txt#308 Android API level 21 have epoll_create1.

@Thomasdezeeuw Thomasdezeeuw merged commit 7074b47 into master Dec 14, 2023
25 checks passed
@Thomasdezeeuw Thomasdezeeuw deleted the remove-work-arounds branch December 14, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove v2.7.x workarounds from Linux code
2 participants